Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(text-field): Added support for text field without label #4285

Merged
merged 19 commits into from
Jan 29, 2019

Conversation

abhiomkar
Copy link
Contributor

Features included:

  • Adds support for text field without label by making floating label element optional for all text field variants.
  • Adds support for placeholder with or without floating label element where placeholder is visible only on focused state for text field that has label.

Fixes #4239

Screenshot:

Copy link
Contributor

@kfranqueiro kfranqueiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems pretty reasonable, but I'd like us to run it by our designers for review before merging.

packages/mdc-textfield/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@kfranqueiro kfranqueiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

golden.json also needs updating.

@abhiomkar
Copy link
Contributor Author

Updated golden screenshots.

Copy link
Contributor

@kfranqueiro kfranqueiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once goldens are updated for the last changes

@abhiomkar abhiomkar merged commit bf956fa into master Jan 29, 2019
@abhiomkar abhiomkar deleted the feat/textfield_without_label branch January 29, 2019 18:11
@jamesmfriedman jamesmfriedman mentioned this pull request Feb 5, 2019
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants