-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(text-field): Added support for text field without label #4285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems pretty reasonable, but I'd like us to run it by our designers for review before merging.
test/screenshot/spec/mdc-textfield/classes/focused-outlined-placeholder.html
Outdated
Show resolved
Hide resolved
test/screenshot/spec/mdc-textfield/classes/focused-baseline-placeholder.html
Outdated
Show resolved
Hide resolved
test/screenshot/spec/mdc-textfield/classes/focused-outlined-placeholder.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
golden.json also needs updating.
🤖 Beep boop! Screenshot test report 🚦19 screenshots changed from Details |
Updated golden screenshots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once goldens are updated for the last changes
🤖 Beep boop! Screenshot test report 🚦15 screenshots changed from |
Features included:
Fixes #4239
Screenshot: