fix(menu): Read index property from list item event detail #4368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression caused by PR #4356, and adds a unit test to catch future integration failures between list and menu events.
Codecov Report
@@ Coverage Diff @@
## master #4368 +/- ##
=========================================
Coverage ? 98.56%
=========================================
Files ? 130
Lines ? 5731
Branches ? 763
=========================================
Hits ? 5649
Misses ? 82
Partials ? 0
Continue to review full report at Codecov.
|
|
All 621 screenshot tests passed for commit 7d0d136 vs. |
kfranqueiro
approved these changes
Feb 7, 2019
|
All 621 screenshot tests passed for commit a8239ef vs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression caused by PR #4356, and adds a unit test to catch future integration failures between list and menu events.