Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(menu): Vertically center the group icon #4862

Merged
merged 2 commits into from
Jun 27, 2019
Merged

fix(menu): Vertically center the group icon #4862

merged 2 commits into from
Jun 27, 2019

Conversation

patrickrodee
Copy link
Contributor

IE11 does not vertically position the group icon when it is followed by a text item. This fixes that behavior.
UBXZKPFOvPi

@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

3 screenshots changed from develop on commit ef1c24d:

Details

@patrickrodee patrickrodee merged commit c5738ed into develop Jun 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the fixMenuGroupIconPositioningInIE11 branch June 27, 2019 19:21
@moog16
Copy link
Contributor

moog16 commented Jun 27, 2019

This can actually be cherry picked into master. This isn't a breaking change.

moog16 pushed a commit that referenced this pull request Jun 27, 2019
@patrickrodee
fix(menu): Vertically center the group icon (#4862)
d551dfd
@abhiomkar abhiomkar mentioned this pull request Jul 9, 2019
Closed
@jamesmfriedman jamesmfriedman mentioned this pull request Nov 4, 2019
Merged
93 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhiomkar abhiomkar abhiomkar approved these changes

@moog16 moog16 moog16 approved these changes

Assignees

@abhiomkar abhiomkar

@moog16 moog16

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@patrickrodee @mdc-web-bot @moog16 @abhiomkar @googlebot