Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(text-field): Add density mixin to text field variants #5066

Merged
merged 1 commit into from Sep 16, 2019
Merged

feat(text-field): Add density mixin to text field variants #5066

merged 1 commit into from Sep 16, 2019

Conversation

abhiomkar
Copy link
Contributor

Fixes #4882

@codecov-io
Copy link

codecov-io commented Sep 10, 2019 •
edited

Codecov Report

Merging #5066 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5066      +/-   ##
===========================================
- Coverage    98.67%   98.65%   -0.02%     
===========================================
  Files          122      122              
  Lines         6029     6029              
  Branches       795      795              
===========================================
- Hits          5949     5948       -1     
- Misses          79       80       +1     
  Partials         1        1
Impacted Files Coverage Δ
packages/mdc-dialog/foundation.ts 98.68% <0%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5132f89...e100f9f. Read the comment docs.

@abhiomkar abhiomkar changed the base branch from feature/density to develop September 10, 2019 23:36
@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

18 screenshots changed from develop on commit 5ca35da:

Details

@abhiomkar abhiomkar force-pushed the feat/density/textfield branch 2 times, most recently from 4f04dab to e61f71c Compare September 13, 2019 19:35
@abhiomkar abhiomkar mentioned this pull request Sep 13, 2019
Closed
@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

18 screenshots changed from develop on commit bf5aff4:

Details

@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

18 screenshots changed from develop on commit e100f9f:

Details

@abhiomkar abhiomkar merged commit a12101d into develop Sep 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/density/textfield branch September 16, 2019 15:21
@abhiomkar abhiomkar mentioned this pull request Sep 16, 2019
Closed
@jamesmfriedman jamesmfriedman mentioned this pull request Nov 4, 2019
Merged
93 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyzhong joyzhong joyzhong approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@abhiomkar @codecov-io @mdc-web-bot @joyzhong @googlebot