Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSE - Archive page #228

Closed
jauyong opened this issue Nov 2, 2021 · 5 comments
Closed

FSE - Archive page #228

jauyong opened this issue Nov 2, 2021 · 5 comments
Assignees
Labels
Projects
Milestone

Comments

@jauyong
Copy link
Collaborator

jauyong commented Nov 2, 2021

Feature description

Create an Archive page template


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  1. Create a default Archive page including:
    1. Title
    2. Subtitle
    3. Page separator
    4. Card Collection
      1. See FSE - Card Collection #237
    5. Pagination
      1. See FSE - Pagination #236
  2. The editor is able to manage the archive page template in FSE

Implementation brief

QA testing instructions

Demo

Changelog entry

@jauyong jauyong added this to To Groom / Define in Execution Nov 2, 2021
@jauyong jauyong self-assigned this Nov 2, 2021
@jauyong
Copy link
Collaborator Author

jauyong commented Nov 2, 2021

@jauyong to create a separate tickets for pagination and Card Collection Template part

@jauyong jauyong moved this from To Groom / Define to To Do in Execution Nov 2, 2021
@jauyong jauyong removed their assignment Nov 11, 2021
@PatelUtkarsh PatelUtkarsh self-assigned this Dec 23, 2021
@mattchungxwp mattchungxwp moved this from To Do to In Progress in Execution Dec 23, 2021
@PatelUtkarsh PatelUtkarsh moved this from In Progress to Code Review in Execution Jan 20, 2022
@igruszkauy
Copy link
Collaborator

igruszkauy commented Jan 26, 2022

@PatelUtkarsh some questions:

  1. I can't I modify the title of the archive page? I can delete the block but I cannot update the text.
  2. AC mentions a subtitle but this is no available and I don't see that in material theme . Should this be part of the scope
  3. Shouldn't I be able to change the settings for the card collection to display as a list to replicate this?
    image

@PatelUtkarsh
Copy link
Collaborator

Hello @igruszkauy,

  1. Yes, This is generated title using WP core block, so you won't able to edit the title only able to style it.
  2. Added term description block. https://fse-mdc-web.pantheonsite.io/category/classic/
  3. We should discuss this one as there are setting at block level and in customizer, so how should we go about overriding or migrate those setting at block level instead and hide since we will depreciate customizer setting at some point in the future.

@PatelUtkarsh
Copy link
Collaborator

To address point 3 we have added #303.

@PatelUtkarsh PatelUtkarsh moved this from Code Review to QA in Execution Feb 18, 2022
@felipebochehin87
Copy link
Collaborator

LGTM.

@felipebochehin87 felipebochehin87 moved this from QA to Demo in Execution Feb 21, 2022
@igruszkauy igruszkauy moved this from Demo to Approval in Execution Mar 1, 2022
Execution automation moved this from Approval to Done Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

5 participants