Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[M3] Component top app bar #404

Closed
PatelUtkarsh opened this issue Aug 3, 2022 · 4 comments · Fixed by #411
Closed

[M3] Component top app bar #404

PatelUtkarsh opened this issue Aug 3, 2022 · 4 comments · Fixed by #411
Projects
Execution
Milestone
M3

Comments

@PatelUtkarsh
Copy link
Collaborator

Feature description

Replace m2's top app bar with m3 tokens: @material/top-app-bar/dist/mdc.top-app-bar.css

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry
@PatelUtkarsh PatelUtkarsh added this to To Groom / Define in Execution Aug 3, 2022
@PatelUtkarsh PatelUtkarsh added this to the M3 milestone Aug 3, 2022
@PatelUtkarsh PatelUtkarsh self-assigned this Aug 9, 2022
@PatelUtkarsh PatelUtkarsh moved this from To Groom / Define to Code Review in Execution Aug 9, 2022
@PatelUtkarsh PatelUtkarsh mentioned this issue Aug 9, 2022
Merged
3 tasks
Execution automation moved this from Code Review to Done Aug 10, 2022
@PatelUtkarsh PatelUtkarsh moved this from Done to QA in Execution Aug 11, 2022
@PatelUtkarsh
Copy link
Collaborator Author

Top app bar:
image

QA Note: Test top app bar with m3 token.

@PatelUtkarsh PatelUtkarsh assigned igruszkauy and unassigned emeaguiar Aug 11, 2022
@igruszkauy
Copy link
Collaborator

Verified via: https://dev-mdc-web.pantheonsite.io/

  1. If I click on "Design" from the top app bar, "Design" and "Components" are visually selected but it takes me to "Components". Same happens when selecting other items.

image

Both are also selected in drawer:

image

@PatelUtkarsh Sending back for review

@igruszkauy igruszkauy moved this from QA to To Do in Execution Aug 12, 2022
@PatelUtkarsh
Copy link
Collaborator Author

Hello @igruszkauy, This is because both design and components points to same link. https://dev-mdc-web.pantheonsite.io/blog-2/.

@PatelUtkarsh PatelUtkarsh moved this from To Do to QA in Execution Aug 16, 2022
@igruszkauy
Copy link
Collaborator

@PatelUtkarsh
Updated the menus links and it's working as expected:
image

@igruszkauy igruszkauy moved this from QA to Demo in Execution Aug 16, 2022
@igruszkauy igruszkauy removed their assignment Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Execution
Demo
Milestone
M3
Development

Successfully merging a pull request may close this issue.

M3 Top app bar material-components/material-design-for-wordpress
3 participants
@emeaguiar @igruszkauy @PatelUtkarsh