Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[M3] Tool tip #406

Closed
PatelUtkarsh opened this issue Aug 3, 2022 · 2 comments · Fixed by #412
Closed

[M3] Tool tip #406

PatelUtkarsh opened this issue Aug 3, 2022 · 2 comments · Fixed by #412
Projects
Execution
Milestone
M3

Comments

@PatelUtkarsh
Copy link
Collaborator

Feature description

Replace m2 style from @material/tooltip/dist/mdc.tooltip.css with m3 color and typography tokens.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry
@PatelUtkarsh PatelUtkarsh added this to the M3 milestone Aug 3, 2022
@PatelUtkarsh PatelUtkarsh added this to To Groom / Define in Execution Aug 3, 2022
@PatelUtkarsh PatelUtkarsh self-assigned this Aug 9, 2022
@PatelUtkarsh PatelUtkarsh moved this from To Groom / Define to To Do in Execution Aug 9, 2022
@PatelUtkarsh PatelUtkarsh moved this from To Do to In Progress in Execution Aug 9, 2022
@PatelUtkarsh PatelUtkarsh mentioned this issue Aug 9, 2022
Merged
3 tasks
@PatelUtkarsh PatelUtkarsh moved this from In Progress to Code Review in Execution Aug 9, 2022
Execution automation moved this from Code Review to Done Aug 10, 2022
@PatelUtkarsh PatelUtkarsh moved this from Done to QA in Execution Aug 11, 2022
@PatelUtkarsh
Copy link
Collaborator Author

Tool tip is used with material button icon block.

tool-tip.mp4

QA note: Test tool tip with m3.

@PatelUtkarsh PatelUtkarsh assigned igruszkauy and unassigned emeaguiar Aug 11, 2022
@igruszkauy
Copy link
Collaborator

Verified via: https://dev-mdc-web.pantheonsite.io/2705-2/

  1. Tooltip displayed as expected for button w/ icon style.

image

  1. Tooltip color adapts when switching light/dark mode

image

@igruszkauy igruszkauy moved this from QA to Demo in Execution Aug 12, 2022
@igruszkauy igruszkauy removed their assignment Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Execution
Demo
Milestone
M3
Development

Successfully merging a pull request may close this issue.

M3 tooltip material-components/material-design-for-wordpress
3 participants
@emeaguiar @igruszkauy @PatelUtkarsh