Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move performer logic to private/ dir #19

Closed
jverkoey opened this issue Oct 11, 2016 · 3 comments
Closed

Move performer logic to private/ dir #19

jverkoey opened this issue Oct 11, 2016 · 3 comments

Comments

@jverkoey
Copy link
Contributor

jverkoey commented Oct 11, 2016

All performer logic should be added to swift files in the src/private sub-directory.

See the Core Animation family for an example: https://github.com/material-motion/material-motion-family-coreanimation-swift/tree/develop/src/private

@rcameron
Copy link
Contributor

Would be worthwhile to mimic the Swift access levels model and call it src/internal since performers will most likely be internal?

@jverkoey
Copy link
Contributor Author

Oh! Interesting question. Our src/private concept comes from our Objective-C conventions. I could get behind introducing a src/internal distinction for swift conventions.

Can you start a discussion about this on the team repo?

@jverkoey jverkoey self-assigned this Oct 31, 2016
@jverkoey
Copy link
Contributor Author

🎊 My diff is ready for review at http://codereview.cc/D1814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants