Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DirectlyManipulable should not expose plans in its public API #23

Closed
jverkoey opened this issue Nov 1, 2016 · 1 comment
Closed

DirectlyManipulable should not expose plans in its public API #23

jverkoey opened this issue Nov 1, 2016 · 1 comment
Assignees
@jverkoey
Labels
Internal cleanup
Projects
sprint: 2016-10-27 to 2016-11-03
Milestone
v1.0.0 release

Comments

@jverkoey
Copy link
Contributor

jverkoey commented Nov 1, 2016

This is leaking the implementation details of the plan.

Instead, let's just expose the gesture recognizers. We intentionally won't expose shouldAdjustAnchorPointOnGestureStart because we always want this property to be true for DirectlyManipulable.
@jverkoey jverkoey added this to the v1.0.0 release milestone Nov 1, 2016
@jverkoey jverkoey self-assigned this Nov 1, 2016
@jverkoey
Copy link
Contributor Author

jverkoey commented Nov 1, 2016

🎊 My diff is ready for review at http://codereview.cc/D1823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jverkoey jverkoey

Labels
Internal cleanup
Projects
sprint: 2016-10-27 to 2016-11-03
Done
Milestone
v1.0.0 release
Development

No branches or pull requests
1 participant
@jverkoey