Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BlockGesturable type #7

Closed
jverkoey opened this issue Aug 16, 2016 · 1 comment
Closed

Remove BlockGesturable type #7

jverkoey opened this issue Aug 16, 2016 · 1 comment

Comments

@jverkoey
Copy link
Contributor

jverkoey commented Aug 16, 2016

This plan is somewhat too powerful in that it allows arbitrary blocks to be provided to it. This can leak separation of concerns back to the creator of the plan.

Example:

BlockGesturable(withGestureRecognizer: gesture) { gesture in
  // Dangerous: access internal state of the registering agent
}
@rcameron
Copy link
Contributor

🎊 My diff is ready for review at http://codereview.cc/D1545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants