Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition object needs to clear its state in the controller #16

Closed
jverkoey opened this issue Oct 19, 2016 · 1 comment
Closed

Transition object needs to clear its state in the controller #16

jverkoey opened this issue Oct 19, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@jverkoey
Copy link
Contributor

The controller holds onto a reference of the transition but never releases it. It should release the transition instance when the transition completes.

The transition should provide a delegate that the controller can assign itself to in order to receive a "didFinish" event. The controller should nil out the transition instance when this event is received.

@jverkoey jverkoey added the Bug label Oct 19, 2016
@jverkoey jverkoey self-assigned this Oct 19, 2016
@jverkoey
Copy link
Contributor Author

🎊 My diff is ready for review at http://codereview.cc/D1735

@jverkoey jverkoey modified the milestone: MVP Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant