Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should only be returning an interaction controller if we intend to be interactive #18

Closed
jverkoey opened this issue Oct 19, 2016 · 1 comment

Comments

@jverkoey
Copy link
Contributor

We currently always treat every transition as an interactive transition. This is somewhat against the intended use of UIKit's transitioning APIs.

What we should be doing is acting as an interactive transition if there is some indication that the transition is, in fact, interactive. One signal we can use to start is whether any gesture recognizers associated with the transition are active.

Until we start working on interactive transitions support (Milestone 2) we may want to consider simplifying the transition controller logic to only implement the animated API variants.

@jverkoey jverkoey self-assigned this Oct 19, 2016
@jverkoey jverkoey modified the milestone: MVP Oct 19, 2016
@jverkoey
Copy link
Contributor Author

🎊 My diff is ready for review at http://codereview.cc/D1736

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant