Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test building heroku container #110

Open
CasperWA opened this issue Aug 30, 2023 · 1 comment · May be fixed by #111
Open

Test building heroku container #110

CasperWA opened this issue Aug 30, 2023 · 1 comment · May be fixed by #111
Assignees
@CasperWA
Labels
enhancement New feature or request

Comments

@CasperWA
Copy link
Contributor

Using herokuish it is possible to test heroku app builds.
Since this theme is used on Materials Cloud, which uses Dokku, this is a good test to see if depending on this repository is viable or if it results in build or installation errors (as is currently the case, see #93).

It is necessary to add a Procfile and probably more in order to make this an installable application.
As an alternative a dummy repository can be created in some .ci sub-folder or similar to mock an app that depends on this repository, which can then be test-built as a CI workflow job.
@CasperWA CasperWA added the enhancement New feature or request label Aug 30, 2023
@CasperWA
Copy link
Contributor Author

Also, this test might be good to get in before merging #109, expecting it to fix the #93 issue. I suspect it might still not work due to the way Heroku installs Python dependencies / the way it runs pip.

@CasperWA CasperWA self-assigned this Aug 30, 2023
@CasperWA CasperWA linked a pull request Aug 30, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CasperWA CasperWA

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add dummy heroku app for CI test CasperWA/voila-materialscloud-template
1 participant
@CasperWA