Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polishing fitting functionality #248

Open
mkhorton opened this issue Jun 7, 2019 · 2 comments
Open

Polishing fitting functionality #248

mkhorton opened this issue Jun 7, 2019 · 2 comments

Comments

@mkhorton
Copy link
Collaborator

mkhorton commented Jun 7, 2019

  • Why does minimum score 0 not work?
  • Be able to supply scores by default in Graph construction
  • Think about how to report error in aggregated quantities
@clegaspi
Copy link
Contributor

clegaspi commented Jun 7, 2019

Regarding the minimum score of 0, that was a constraint Joey added, that the minimum must be 5% weight. @montoyjh was there a specific reason?

@mkhorton
Copy link
Collaborator Author

mkhorton commented Jun 7, 2019

Yes, I understand the default is 0.05, but if you set it to 0 the fitting just doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants