Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection of force-field models to phonon workflow #371

Closed
JaGeo opened this issue Jun 5, 2023 · 5 comments · Fixed by #398
Closed

Connection of force-field models to phonon workflow #371

JaGeo opened this issue Jun 5, 2023 · 5 comments · Fixed by #398

Comments

@JaGeo
Copy link
Member

JaGeo commented Jun 5, 2023

@QuantumChemist and I plan to work on connection between the force field methods and a phonon workflow.

@matthewkuner
Copy link
Collaborator

matthewkuner commented Jun 8, 2023

@JaGeo @QuantumChemist I plan on adding M3GNet support to the Atomate2 forcefields methods soon, in case that affects your plans

@JaGeo JaGeo changed the title Feature Connection of force-field models to phonon workflow Jun 8, 2023
@JaGeo
Copy link
Member Author

JaGeo commented Jun 8, 2023

@matthewkuner Thank you! I think we will try to generalize the phonon workflow in such a way that it should work with all future ML models/force fields. Hopefully, we can also support more quantum-chemical codes at some point.

@matthewkuner
Copy link
Collaborator

matthewkuner commented Jun 8, 2023

@JaGeo Cool cool. I do not currently plan on changing the ForceFieldTaskDocument anytime soon, which I assume will make your phonon stuff easier to maintain.

Hopefully, we can also support more quantum-chemical codes at some point.

What do you mean by this? Like supporting Quantum Espresso or other DFT codes?

@JaGeo
Copy link
Member Author

JaGeo commented Jun 8, 2023

What do you mean by this? Like supporting Quantum Espresso or other DFT codes?

Currently, the phonon workflow only works for VASP. I hope we can maybe connect it to Abinit (a pull request exists for static and relax runs, band structures etc) or CP2K at some point as well! 😀 It's probably not a large change. If someone wants to write a QE interface, it's probably also easy to connect

@QuantumChemist
Copy link
Contributor

@matthewkuner yeah, not changing the ForceFieldTaskDocument (much) is really appreciated 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants