Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Error in running bandstructure workflow #616

Closed
nhew1994 opened this issue Nov 20, 2023 · 11 comments
Closed

BUG: Error in running bandstructure workflow #616

nhew1994 opened this issue Nov 20, 2023 · 11 comments

Comments

@nhew1994
Copy link

Describe the bug
I'm going through the atomate2 bandstructure tutorial: https://materialsproject.github.io/atomate2/user/running-workflows.html.

After I submit my job, I get the following error:
2023-11-19 21:50:11,122 INFO Started executing jobs locally
2023-11-19 21:50:11,126 INFO Starting job - relax 1 (eaba6cfb-64af-45f2-b9a0-616a23bf98cd)
2023-11-19 21:50:33,584 INFO Finished job - relax 1 (eaba6cfb-64af-45f2-b9a0-616a23bf98cd)
2023-11-19 21:50:33,585 WARNING Response.stored_data is not supported with local manager.
2023-11-19 21:50:33,588 INFO Starting job - relax 2 (772ed0c5-8a6d-4ee8-8ae5-d74da60dd2ce)
2023-11-19 21:50:33,698 INFO relax 2 failed with exception:
Traceback (most recent call last):
File "/storage/home/njh5724/.conda/envs/atomate2/lib/python3.9/site-packages/jobflow/managers/local.py", line 102, in run_job
response = job.run(store=store)
File "/storage/home/njh5724/.conda/envs/atomate2/lib/python3.9/site-packages/jobflow/core/job.py", line 572, in run
self.resolve_args(store=store)
File "/storage/home/njh5724/.conda/envs/atomate2/lib/python3.9/site-packages/jobflow/core/job.py", line 678, in resolve_args
resolved_args = find_and_resolve_references(
File "/storage/home/njh5724/.conda/envs/atomate2/lib/python3.9/site-packages/jobflow/core/reference.py", line 458, in find_and_resolve_references
resolved_references = resolve_references(
File "/storage/home/njh5724/.conda/envs/atomate2/lib/python3.9/site-packages/jobflow/core/reference.py", line 353, in resolve_references
resolved_references[ref] = ref.resolve(
File "/storage/home/njh5724/.conda/envs/atomate2/lib/python3.9/site-packages/jobflow/core/reference.py", line 178, in resolve
data = MontyDecoder().process_decoded(data)
File "/storage/home/njh5724/.conda/envs/atomate2/lib/python3.9/site-packages/monty/json.py", line 484, in process_decoded
return cls
(data)
File "/storage/home/njh5724/.conda/envs/atomate2/lib/python3.9/site-packages/pydantic/main.py", line 164, in init
pydantic_self.pydantic_validator.validate_python(data, self_instance=pydantic_self)
File "/storage/home/njh5724/.conda/envs/atomate2/lib/python3.9/site-packages/monty/json.py", line 263, in validate_monty_v2
return cls._validate_monty(__input_value)
File "/storage/home/njh5724/.conda/envs/atomate2/lib/python3.9/site-packages/monty/json.py", line 246, in _validate_monty
new_obj = cls(
__input_value)
TypeError: init() got an unexpected keyword argument 'ALGO'

2023-11-19 21:50:33,705 INFO Finished executing jobs locally

I am using monty==2023.11.3
Let me know if you need any more information or if you know how to fix this problem.

@utf
Copy link
Member

utf commented Nov 20, 2023

Thanks for the bug report. There seems to be an incompatibility with the latest emmet and monty versions.

@janosh are you able to look into this?

@utf
Copy link
Member

utf commented Nov 20, 2023

@nhew1994 could you try updating emmet?

@nhew1994
Copy link
Author

Thanks @utf for the reply. Do you mean emmet-core? When I do pip install atomate2, there is no emmet, only emmet-core. I'm trying different versions of emmet-core at the moment.

@utf
Copy link
Member

utf commented Nov 20, 2023

Yep, I meant emmet-core. Let me know if a more recent version of emmet fixes it for you.

@nhew1994
Copy link
Author

I've tried emmet-core>=0.72.18 with monty==2023.11.3. Still getting the python traceback. The first structure optimization folder will run, but the other folders are empty. Which versions are you using?

@gpetretto
Copy link
Contributor

Following the discussion in the other issue I checked and this is not related to the change I made in monty. It is due to a change in pydantic 2.5. I have found the source of the issue. I will open a PR on monty to address that.

@utf
Copy link
Member

utf commented Nov 21, 2023

Thanks very much for checking @gpetretto

@nhew1994
Copy link
Author

nhew1994 commented Nov 21, 2023

Thanks @gpetretto and @utf. Do I just wait for the pull request on monty: https://github.com/materialsvirtuallab/monty, then reinstall monty?

@nhew1994 nhew1994 mentioned this issue Dec 5, 2023
@lihaojie87
Copy link

I have the same problem, is there any solution?

@gpetretto
Copy link
Contributor

The solution at the moment should be to install pydantic 2.4.2.
As far as I could test this materialsvirtuallab/monty#597 should fix the problem, but I am afraid that, until that PR is merged, downgrading pydantic is the only option.

@utf
Copy link
Member

utf commented Feb 29, 2024

This is now fixed in version 0.1.14

@utf utf closed this as completed Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants