Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate RGB values for elements in ElementColorSchemes.yaml #359

Open
tsmathis opened this issue Jul 21, 2023 · 3 comments
Open

Duplicate RGB values for elements in ElementColorSchemes.yaml #359

tsmathis opened this issue Jul 21, 2023 · 3 comments

Comments

@tsmathis
Copy link
Collaborator

Two sets of two elements share duplicate RGB values in the VESTA color scheme in ElementColorSchemes.yaml. This leads to visual ambiguity in the rendered structures for materials with these elements in their chemical system.

VESTA:
F and N : [176, 185, 230]
Sr and Zr: [0, 255, 0]

Some examples: mp-770419, mp-601344

@mkhorton
Copy link
Member

This is true, but not our choice: these are reference color schemes determined by others.

I completely support the addition of a new Crystal Toolkit color scheme however, which we can make a default. Happy to discuss.

@mkhorton
Copy link
Member

Aside: this partly motivated the addition of the “Accessible” color scheme. This used a reference color scheme from literature suitable for people with color blindness, and constrained atoms to be their “regular” color if possible (i.e. close to CPK, oxygen red etc.)

This scheme is not fully successful yet since one of the colors in that scheme is white, so to really reach accessibility goals, it’d probably be better off switching to a black/darker viewport background when that scheme is enabled, or simply changing the white atom color to something else, but this was on the backlog.

@tsmathis
Copy link
Collaborator Author

Good to know. Color schemes came up in a MP update call a few weeks ago in a related context, I can bring it up again in the next call to see what everyone thinks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants