Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_criteria directly invokes mongo commands #38

Closed
shyamd opened this issue Sep 26, 2018 · 1 comment
Closed

get_criteria directly invokes mongo commands #38

shyamd opened this issue Sep 26, 2018 · 1 comment

Comments

@shyamd
Copy link
Contributor

shyamd commented Sep 26, 2018

Ideally the Store abstracts away database specific commands. get_criteria calls pymongo calls directly. It would be better if it called Store methods and the Stores used the correct calls internally.
@shyamd
Copy link
Contributor Author

shyamd commented Aug 28, 2019

Fixed in a216eb4

@shyamd shyamd closed this as completed Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shyamd