Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: pass keyword arguments to zopen to accommodate non english platforms #932

Closed
rkingsbury opened this issue Mar 25, 2024 · 2 comments
Assignees

Comments

@rkingsbury
Copy link
Collaborator

Problem

User needs to be able to pass kwargs through to zopen (e.g., in JSONStore) in order to accommodate non-english platforms.

See materialsvirtuallab/monty#641 (comment)

zopen fails on some language platforms due to lack of explicit encoding (UnicodeDecodeError) #641

Proposed Solution

  • Identify anywhere in maggma that uses zopen
  • Add passthrough kwargs from the Store.__init__ method to zopen so that users of other platforms can explicitly set character encoding

Alternatives

No response

@rkingsbury
Copy link
Collaborator Author

See also KingsburyLab/pyEQL#122 (comment)

@rkingsbury rkingsbury changed the title [Feature Request]: [Feature Request]: pass keyword arguments to zopen to accommodate non english platforms Mar 25, 2024
@rkingsbury rkingsbury self-assigned this May 13, 2024
@rkingsbury
Copy link
Collaborator Author

rkingsbury commented May 13, 2024

Added by #949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant