Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broken BSPlotterProjected.get_projected_plots_dots_patom_pmorb #3647

Closed
fraricci opened this issue Feb 22, 2024 · 0 comments · Fixed by #3651
Closed

broken BSPlotterProjected.get_projected_plots_dots_patom_pmorb #3647

fraricci opened this issue Feb 22, 2024 · 0 comments · Fixed by #3651
Labels
bug data viz PRs and issues about pymatgen plotting functionality electronic structure Electronic structure functionality related

Comments

@fraricci
Copy link
Contributor

fraricci commented Feb 22, 2024 •
edited

This line has been changed in #2862:
https://github.com/materialsproject/pymatgen/blame/38b9b58f16a9528cb2c8f0bc0c7889955687ae8e/pymatgen/electronic_structure/plotter.py#L1740

and the replacement of the intersection function with a & brakes the code since the second item is not a set but a list.

Solutions:

  • either change it back to using the intersection function
  • make a set of that list

I'm wondering how the tests are passing...
@janosh janosh added bug data viz PRs and issues about pymatgen plotting functionality electronic structure Electronic structure functionality related labels Feb 23, 2024
@janosh janosh mentioned this issue Feb 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug data viz PRs and issues about pymatgen plotting functionality electronic structure Electronic structure functionality related
Projects
None yet
Milestone
No milestone
2 participants
@fraricci @janosh