Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] support for php 7.4 #62

Closed
DBTK1990 opened this issue Jan 5, 2022 · 1 comment
Closed

[FEATURE REQUEST] support for php 7.4 #62

DBTK1990 opened this issue Jan 5, 2022 · 1 comment
Assignees

Comments

@DBTK1990
Copy link

DBTK1990 commented Jan 5, 2022

Is your feature request related to a problem? Please describe.
run application on env with php 7.4

Describe the solution you'd like
support for php 7.4

Describe alternatives you've considered
run transpiler on your code to adjust it to php 7.4

Additional context
you can do this easily with rector/rector package
i forked your repo you can take a look (my-forked-repo) at my config for the rector compiler
i got only one failed test , something with one of the option so not so bad

please consider this

@mateusjunges
Copy link
Owner

Hi @DBTK1990
I have no plans to add PHP 7.4 support for this project, Personally i think php 8 has a much cleaner code syntax and is much easier to maintain. You can release your fork as a new version for this project, supporting PHP 7.4. If you do it, let me know and i'll pin this issue so people who wants to use this package on php 7.4 can find your code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants