Get the description from OpenLibrary #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusz-bak
reviewed
Apr 24, 2023
mateusz-bak
reviewed
Apr 24, 2023
lib/ui/search_ol_editions_screen/search_ol_editions_screen.dart
Outdated
Show resolved
Hide resolved
mateusz-bak
reviewed
Apr 24, 2023
|
Hi @fabix please rebase your branch as it does not work on Flutter 3.10.5 after I updated master. If that's a problem let me know and I will try to just take the changes you made there. |
|
is it ok now? |
mateusz-bak
reviewed
Jun 23, 2023
| @@ -192,6 +194,7 @@ class _SearchOLEditionsScreenState extends State<SearchOLEditionsScreen> { | |||
| onPressed: () => _saveEdition( | |||
| result: item, | |||
| cover: item.covers![0], | |||
| work: item.works![0].key, | |||
There was a problem hiding this comment.
I think this is not null safe. What do you think about:
work: item.works != null && item.works!.isNotEmpty ? item.works![0].key : null,
mateusz-bak
reviewed
Jun 23, 2023
| @@ -40,6 +40,7 @@ class _SearchOLScreenState extends State<SearchOLScreen> | |||
| required String title, | |||
| String? subtitle, | |||
| required String author, | |||
| String? description, | |||
There was a problem hiding this comment.
I think this is not necessary as description will be downloaded on the AddBookScreen.
mateusz-bak
reviewed
Jun 23, 2023
| @@ -50,6 +51,7 @@ class _SearchOLScreenState extends State<SearchOLScreen> | |||
| title: title, | |||
| subtitle: subtitle, | |||
| author: author, | |||
| description: description, | |||
|
Tested, works good. Just please check the review comments. |
|
Changes done. To be honest, it's the first time I write in dart (and modify an Android app), so it's far from perfect 😄 ... |
|
It's good, don't worry and thank you for the contributions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.