Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Search cannot find ebooks #116

Closed
matthias4217 opened this issue Jun 9, 2022 · 2 comments · Fixed by #127
Closed

[BUG] Search cannot find ebooks #116

matthias4217 opened this issue Jun 9, 2022 · 2 comments · Fixed by #127
Assignees
Labels
bug Something isn't working

Comments

@matthias4217
Copy link

Describe the bug

When looking for an ebook from OpenLibrary, such as Black Library Celebration 2022, I cannot find it using the Openreads search.

To Reproduce

Unfortunately, I haven't found much ebooks in OpenLibrary. The only ones I have found are the ones I have added. I'd like to have some more examples, because maybe I've made a mistake when adding those ?

Expected behavior

Maybe this is a design choice, but since I read some ebooks, I'd like to add them to the app from OpenLibrary and not only manually. I've looked a bit at the code, but my poor level in Kotlin and Android hasn't helped me find where this issue could come from.

Additional info(please complete the following information):

  • Manufacturer and model: LG G5
  • Android version: 11
  • App version: 1.14.2
  • App source (F-Droid, Google Play, Github): F-Droid

Additional context

I really love Openreads ! Thank you very much for your work !

@matthias4217 matthias4217 added the bug Something isn't working label Jun 9, 2022
@mateusz-bak
Copy link
Owner

Hey @matthias4217 thank you for submitting this issue! I will check why there's a problem with ebooks. Cheers!

@mateusz-bak
Copy link
Owner

Ok found the issue: search for this books returns a record with two ISBN numbers that are missing from Open Library. App will look up the book also by Open Library ID.
Currently it would search by OLID only when ISBN was missing.

Thanks for the contribution, fix will be released in v1.16.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants