Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Source doesn't display Product types list #2

Closed
wmdhosting opened this issue Mar 16, 2022 · 12 comments
Closed

Product Source doesn't display Product types list #2

wmdhosting opened this issue Mar 16, 2022 · 12 comments
Labels
bug Something isn't working

Comments

@wmdhosting
Copy link

wmdhosting commented Mar 16, 2022

Snag_2224650

Snag_222c488

@matfish2
Copy link
Owner

matfish2 commented Mar 16, 2022

"Not possible to change once saved" - This is by design (imagine you have defined columns already. Changing data source wouldn't make sense). See here: https://matanya.gitbook.io/craft-tablecloth/table-definition/data-source:

Once you save the data source it cannot be altered. Create a new table if you require a different data source

"No product types listed" - I need to check. Once you select Product data source the "Section" dropdown should be replaced with "Product Type" like so:
blogify-dev test_admin_tablecloth_tables_new (5)

@matfish2 matfish2 changed the title Me again :) Product Source doesn't display Product types list Mar 16, 2022
@matfish2
Copy link
Owner

Any JavaScript errors in console?

@wmdhosting
Copy link
Author

Snag_2377c3e

@matfish2
Copy link
Owner

matfish2 commented Mar 16, 2022

Please can you type Tablecloth.productTypes in the console and paste the output.
You should get an array:
Screenshot 2022-03-16 17 05 23

@matfish2
Copy link
Owner

I think I know the source of the issue. Can you select "Data source" Section and then section type "Default". Then replace data source to "Product". I think I need to reset the type selection when data source is changed.

@wmdhosting
Copy link
Author

OK. didnt get anythign with..
Tablecloth.productTypes

@matfish2
Copy link
Owner

matfish2 commented Mar 16, 2022

OK. didnt get anythign with.. Tablecloth.productTypes

Can you share a screenshot? Was there no output at all?

@wmdhosting
Copy link
Author

after.. some swithing.. got it..

Snag_24cdecb

got it..

@matfish2 matfish2 reopened this Mar 16, 2022
@wmdhosting
Copy link
Author

its ok now.. :)

@matfish2
Copy link
Owner

Can you please try with 1.0.0-beta.12. Should be fixed.

  • Added a "select type" default option
  • Reset the type when data source select is changed.

@matfish2
Copy link
Owner

its ok now.. :)

Keep 'em coming :)

@wmdhosting
Copy link
Author

:)

@matfish2 matfish2 added the bug Something isn't working label Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants