Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter display opacity doesn't match with the filter value and click is not disabled #57

Open
davideas opened this issue Feb 4, 2022 · 0 comments

Comments

@davideas
Copy link

davideas commented Feb 4, 2022

Bugs description:

  1. Visual opacity doesn't reflect the filter value:
    I have a working hours filter that I copied from your example:
if (unit === 'hour') {
    // Prevent office hours from being selected.
    return hour >= 6 && hour <= 19;
}

But the hour 5 looks clickable (opacity = 1) and 19 has opacity while should be full black.

  1. The Click on hours with opacity is actually triggering the view for minutes selection, while it should do nothing and remain in the view for hour selection as indeed those hours are not selectable!
    EDIT: Bug seems present only in Time view, while in DateTime view click is not allowed, which is ok.

Expected behavior

Opacity of the hours should respect the condition the filter is returning.
The click on hours and minutes should be ignored and remains in the same view.

Screenshots

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant