Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front end work to re-organize DB connections #3297

Closed
Tracked by #3294
seancolsen opened this issue Nov 6, 2023 · 4 comments · Fixed by #3326
Closed
Tracked by #3294

Front end work to re-organize DB connections #3297

seancolsen opened this issue Nov 6, 2023 · 4 comments · Fixed by #3326
Assignees
Labels
ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Milestone

Comments

@seancolsen
Copy link
Contributor

seancolsen commented Nov 6, 2023

Per the DB Connections Page Specs, we need the following changes.

Database page

  • Remove this sidebar

    image

Connections page

  • Modify route

    • Old: /administration/db-connection/
    • New: /connections/
  • Ensure the header navigation breadcrumb includes: the elephant and name, then the database switcher dropdown, then a "Connections" breadcrumb entry with the plug icon.

  • Implement new page content design (Figma)

    image

  • Leave an empty placeholder modal for the "New Database Connection" form, as to be implemented in Front end changes for the "New Database Connection" form #3311.

  • Re-organize components to better suit the new location of this page

  • Navigation

    • Add "Manage Connections" link within the database switcher dropdown

      image

    • Add "Database Connections" link within the top right menu

      image

    • Remove "Database Connection" section from Administration navigation

      image

Root route

  • Modify redirection logic
    • Old: redirect to the database page for the connection with the highest id
    • New: If there is one and only one connection, then redirect to the database page for that connection. Otherwise, redirect to /connections/

Navigation header

  • Simplify the elephant logo and "Mathesar" text alongside it.

    • Currently, it's a hyperlink with a dynamic href depending on the current page. For any pages within a database connection, it points to the database page, and for other pages it points to the root route.
    • Instead, it should always point directly to the root route. (No more dynamic behavior.) The navigation behavior when clicking it will then be subject to the redirection logic described above.

Note

This ticket is labeled "frontend" because the majority of the changes here are strictly frontend changes. However it will also require a tiny bit of backend changes for the page routing adjustments.

@seancolsen seancolsen added ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory labels Nov 6, 2023
@seancolsen seancolsen added this to the v0.1.4 milestone Nov 6, 2023
@seancolsen seancolsen self-assigned this Nov 6, 2023
@kanugurajesh

This comment was marked as off-topic.

@dikwickley

This comment was marked as off-topic.

@seancolsen

This comment was marked as off-topic.

@seancolsen seancolsen assigned pavish and unassigned seancolsen Nov 17, 2023
@seancolsen seancolsen changed the title Front end work for new DB connections functionality Front end work to re-organize DB connections Nov 17, 2023
@pavish
Copy link
Member

pavish commented Nov 30, 2023

The route modification:

- Modify route
    - Old: `/db/<connection_name>/`
    - New: `/db/<connection_id>/`

is spun into a new issue: #3328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready for implementation type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants