Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI pipeline workflow to check for TypeScript errors #877

Closed
seancolsen opened this issue Dec 9, 2021 · 1 comment · Fixed by #1025
Closed

Add CI pipeline workflow to check for TypeScript errors #877

seancolsen opened this issue Dec 9, 2021 · 1 comment · Fixed by #1025
Labels
type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory work: other

Comments

@seancolsen
Copy link
Contributor

From what I can tell, we don't have any continuous integration checks in place to verify the absence of TypeScript errors.

I think we need to add:

  • svelte-check to check *.svelte files
  • tsc --noEmit to check *.ts files

Does that sound good, @pavish?

@seancolsen seancolsen added type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory work: other status: draft labels Dec 9, 2021
@seancolsen seancolsen added this to the [08.1] 2022-01 improvements milestone Dec 9, 2021
@seancolsen seancolsen changed the title Check for TypeScript errors in our CI pipeline Add CI pipeline workflow to check for TypeScript errors Dec 9, 2021
@pavish
Copy link
Member

pavish commented Dec 13, 2021

@seancolsen We could configure svelte-check to also check ts files by passing the tsConfig file to it. Refer --tsconfig option in docs.

I'm not sure if this might introduce other issues, in which case we can go with tsc --noEmit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request work: frontend Related to frontend code in the mathesar_ui directory work: other
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants