Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and use only yarn.lock #19

Merged

Conversation

ansidev
Copy link
Contributor

@ansidev ansidev commented Jan 3, 2019

No description provided.

@matheusgrieger
Copy link
Owner

Everything looks good! But why did you remove package-lock.json? There are no problems in keeping yarn.lock, but there is a fair amount of people using npm instead of yarn.

@ansidev
Copy link
Contributor Author

ansidev commented Jan 4, 2019

@matheusgrieger I don't recommend using both pack manager, just one, but it 's up to you. I can add package-lock.json again.

@matheusgrieger
Copy link
Owner

I would prefer that, yes.

As npm is currently the "standard" (considering it is installed by default with Node), I assume is what most people use.

Aside from that, everything else looks great, and what you changed is really nice, thank you.

@ansidev
Copy link
Contributor Author

ansidev commented Jan 4, 2019

@matheusgrieger Done!

@ansidev
Copy link
Contributor Author

ansidev commented Jan 4, 2019

@matheusgrieger You are welcome!

@matheusgrieger matheusgrieger merged commit d8a9918 into matheusgrieger:master Jan 4, 2019
@matheusgrieger
Copy link
Owner

I will be publishing a new version soon. Again, thank you.

@ansidev ansidev deleted the feature/update-dependencies branch January 4, 2019 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants