Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for Spinner component #48

Closed
matheusps opened this issue Oct 22, 2019 · 2 comments
Closed

Add tests for Spinner component #48

matheusps opened this issue Oct 22, 2019 · 2 comments
Assignees
@fedebabrauskas
Labels
chore hacktoberfest

Comments

@matheusps
Copy link
Owner

The tests should check if:

  • The component renders without crashing
  • The component renders correctly for all gaps
  • The component renders correctly for all thickness
  • The component renders correctly for all gaps
  • The component renders correctly for all speeds
@fedebabrauskas fedebabrauskas mentioned this issue Oct 23, 2019
Merged
@fedebabrauskas
Copy link
Contributor

fedebabrauskas commented Oct 23, 2019 •
edited

Can I be assigned for this one too?

Thank you.

EDIT:

  • I opened a PR about this issue, check it below 😄
  • Please ignore the previous reference, it was a mistake.

@fedebabrauskas fedebabrauskas mentioned this issue Oct 23, 2019
Merged
@matheusps
Copy link
Owner Author

No problem, assigned to you 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedebabrauskas fedebabrauskas

Labels
chore hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matheusps @fedebabrauskas