Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve csx tests #1

Closed
matheusps opened this issue Oct 19, 2019 · 3 comments
Closed

Improve csx tests #1

matheusps opened this issue Oct 19, 2019 · 3 comments
Labels
bug Something isn't working hacktoberfest

Comments

@matheusps
Copy link
Owner

Add tests for undefined and null on csx.test

@matheusps matheusps added bug Something isn't working hacktoberfest labels Oct 19, 2019
@matheusps matheusps changed the title Improve csx testing Improve csx tests Oct 19, 2019
@taksuparth
Copy link

taksuparth commented Oct 20, 2019

@matheusps giving undefined or null in csx function will result in a type error, because it expects argument's type to be either string, number or object with key value pair. So, no need to write test cases for scenarios which is not going to happen. Or we can change type of csx function to take input undefined and null and then write test cases for that.

@matheusps
Copy link
Owner Author

matheusps commented Oct 20, 2019

@taksuparth Thanks in advance for contributing. I think we can change the signature to accept these values and if they are passed, return an empty string. Check issue #3

@taksuparth
Copy link

@matheusps sounds cool! I will take that up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants