Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there anything that needs to be maintained? #5

Open
towc opened this issue Nov 21, 2019 · 2 comments
Open

Is there anything that needs to be maintained? #5

towc opened this issue Nov 21, 2019 · 2 comments

Comments

@towc
Copy link

towc commented Nov 21, 2019

This is great and I love that it exists, blowing complicated ORMs out of the water.

But I've felt reluctant to use it simply because it hasn't been updated in 3 years.

There are a decent amount of tests, and everything still seems relevant to me.

Is there anything else that might need maintenance, to keep the project active and make people like me more confident in picking this tool?

@towc
Copy link
Author

towc commented Nov 21, 2019

For example, there's some minor formatting inconsistencies in the readme (which I'd be happy to make a PR to fix), and I feel the base class could use more straight forward code with less hidden variables. As far as I understand, Config's purpose could be completely encapsulated within Base, too.

Anyone agrees with this changes?

@towc
Copy link
Author

towc commented Nov 21, 2019

Then the code uses .spread quite a bit, which is bluebird-specific and doesn't exist in es promises. This might break future knex implementations (there is intent to do it: knex/knex#2936, knex/knex#1588). I could possibly prioritize this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant