Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gz() is inefficient #1042

Open
Rudxain opened this issue Mar 15, 2023 · 2 comments · May be fixed by #1044
Open

gz() is inefficient #1042

Rudxain opened this issue Mar 15, 2023 · 2 comments · May be fixed by #1044

Comments

@Rudxain
Copy link

Rudxain commented Mar 15, 2023

It uses wc -c which iterates over every single byte, when counting the size. I know wc is portable, but I suggest we use an alternative that does a syscall to fetch the size directly from the filesystem
@mathiasbynens
Copy link
Owner

Mind sending a patch?

@Rudxain

This comment was marked as outdated.

Sign in to view
@Rudxain Rudxain linked a pull request Mar 16, 2023 that will close this issue
Open
@Rudxain Rudxain changed the title gz fn is inefficient gz() is inefficient Mar 17, 2023
@LucasLarson LucasLarson mentioned this issue Mar 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace wc by stat in gz Rudxain/dotfiles
2 participants
@mathiasbynens @Rudxain