-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
emoji-regex/text match string contains number #14
Comments
That’s the expected behavior. E.g.
Per spec, they’re only supposed to be rendered in emoji form when followed by a variation selector: http://unicode.org/Public/emoji/5.0/emoji-sequences.txt But since you’re using the |
Thanks @mathiasbynens I guess we will need to handle on our side then 👍 cheers |
emoji-regex matches emoji according to the Unicode Standard. It sounds like you want to do something else — how do you determine what’s an emoji and what isn’t? |
Yes, we are parsing a string and try to extract the emoji, currently after parsing we are getting the number which probably shouldnt present as Emoji in our case |
we basically just split the sentence and check individual |
You didn’t answer the question — for your use case, how do you decide what constitutes an emoji and what isn’t? |
We add a flag for parsed emoji which match the unicode spec and check if browser render an emoji (icon) for that purely. |
Checked the spec, probably we want to exclude 0023 ; Emoji # 1.1 [1] (#️) number sign But you are absolutely correct, those are consider valid emoji. |
When the string has number inside, emoji-regex/text matches it
version 6.4.0
The text was updated successfully, but these errors were encountered: