Add certificate property to check if the certificate is valid or not

[xkill]

Hi,

There is no easy way to check if a certificate is valid or not based on expiration date or revoked.

I suggest to add two properties:

"expired": like "revoked" but checking if the cert is expired or not
"valid": return true if not revoked or expired or false if expired or revoked.

[mathiasertl]

Hi!

Thanks for your suggestion. I'm not quite sure what area you are talking about. The Model class in the code? The command-line interface? The web interface?

[xkill]

The Model class.

• Certificate.revoked # already implemented
• Certificate.expired:

from datetime import datetime
def expired(self):
    return self.certificate.x509.not_valid_before > datetime.now()

• Certificate.valid:

def valid(self):
    return self.revoked() or self.expired()

You can also add it on the Admin list view as a boolean property.

[mathiasertl]

The latter would mean the certificate is "valid" if it is either revoked or expired. Is that really what you want?

[xkill]

Yes.

[mathiasertl]

However, the opposite is true. A certificate is valid if it is neither revoked nor expired. Thus closing.