Python Version Compatibility Bugs

[jptiilik]

How did it happen?

1. Open existing Sketch file (5 pages with artboard + Symbols page) on Sketch 44 (41411)
2. Install the plugin
3. Select: Plugins > Git > Advanced > Generate files for pretty diffs

Error log

Traceback (most recent call last):
  File "/Users/Petteri/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Git 2.sketchplugin/getArtboardNames.py", line 15, in <module>
    name = pageName + "/" + artboardName
TypeError: can't concat bytes to str

[jptiilik]

Caught a new one with a bit more info. Any idea what is going on?

Traceback (most recent call last):
  File "/Users/Petteri/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Git 2.sketchplugin/getArtboardNames.py", line 5, in <module>
    obj = json.load(sys.stdin)
  File "/Users/Petteri/.pyenv/versions/3.4.3/lib/python3.4/json/__init__.py", line 265, in load
    return loads(fp.read(),
  File "/Users/Petteri/.pyenv/versions/3.4.3/lib/python3.4/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 6642: ordinal not in range(128)

[mathieudutour]

hum not sure. Is there some "weird" characters in your pages/artboard names?

[jptiilik]

Nothing weird, just ASCII characters from 97 to 122 (lowercase english). To be sure I renamed all the pages and artboards to get rid of possible invisible characters.

Maybe something to do with Python ASCII encoding? A quick Google search: TypeError: can't concat bytes to str gives multiple results, like http://stackoverflow.com/questions/606191/convert-bytes-to-a-python-string?rq=1

[mathieudutour]

Oh what version of python do you have? I think in python3, there is no implicit conversion anymore.

Hum can you try opening the file in question (plugins > manage plugins > the small cog > show plugins folder > right click Git.sketchplugin > show package contents > getArtboardNames.py) and change the line 15 to name = pageName.decode("utf-8") + "/" + artboardName.decode("utf-8")? Is it working?

[jptiilik]

I have python 3.6.1 (latest). I tested it with 2.7.8 and it works nicely!

With 3.6.1, after modifying getArtboardNames.py, the error goes away, but there is a new one:

Traceback (most recent call last):
  File "/Users/Petteri/Library/Application Support/com.bohemiancoding.sketch3/Plugins/Git.sketchplugin/getArtboardNames.py", line 17, in <module>
    if len(ignore) == 0 or all(regex.match(name) == None for regex in ignore):
TypeError: object of type 'map' has no len()

This is explained here: http://stackoverflow.com/questions/21572840/map-object-has-no-len-in-python-3-3. I don't know python good enough to fix this myself.

[kidGodzilla]

I'm also experiencing this bug, latest Sketch, Python 3.6.4, no special characters (script is attempting to concat 'Page 1' and 'Artboard', but one of these is not a string). Going to dig into this more and see if I can build locally / debug.

[mathieudutour]

fixed in 0.12