Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when referencing JS in HTML instead of via a bundler ( BodyScrollLock, dayJS dependencies and its onOpen, onClose events) #110

Open
TrendyTim opened this issue Apr 25, 2024 · 0 comments

Comments

@TrendyTim
Copy link

Even though this seems to be a dead project, just thought id mention this here for anyone else going to use this project outside a bundler.

This is unworkable in its current state when used in webpages when just referencing the JS

Even if you include body scroll lock and dayjs dependencies and apply a fix for case discrepancies.

<script>
BodyScrollLock = bodyScrollLock; Dayjs=dayjs;
</script>

it ignores the vue recommendations for event naming and emits onOpen and onClose making them impossible to handle (why vue never just enforced lowercase for event names i dont know).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant