Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test checking output string fails in localized Windows #20

Closed
tautologico opened this issue Feb 5, 2017 · 7 comments
Closed

Test checking output string fails in localized Windows #20

tautologico opened this issue Feb 5, 2017 · 7 comments

Comments

@tautologico
Copy link

Running tests on a Windows configured to a Brazil locale fails one test because the system uses comma for separating the integer and fractionary parts in a floating-point number, instead of a dot. Test output:

1) Failed : Tests.Constant Expressions
  String lengths are both 5. Strings differ at index 1.
  Expected: "3.2*x"
  But was:  "3,2*x"
@tautologico tautologico changed the title Test checking output string will fail in localized Windows Test checking output string fails in localized Windows Feb 5, 2017
@FoggyFinder
Copy link
Contributor

well, it's easy to fix:

#21

@cdrnet
Copy link
Member

cdrnet commented Feb 7, 2017

I wonder whether it is wise to allow such culture variation in this formal mathematical language. This would make it rather hard to support expression lists, e.g. to describe a matrix. Instead we could enforce the invariant culture everywhere (I'm actually surprised we're not doing this already).

@tautologico
Copy link
Author

It's probably better to have invariant syntax anyway, as programming languages do.

@cdrnet
Copy link
Member

cdrnet commented Feb 9, 2017

@FoggyFinder what are your thoughts, would this work for you as well?

@FoggyFinder
Copy link
Contributor

@cdrnet I agree, it's nice idea

@tautologico
Copy link
Author

I believe this can be closed now, right?

@cdrnet
Copy link
Member

cdrnet commented Feb 12, 2017

Invariant culture is now enforced, released in v0.14.0.

@cdrnet cdrnet closed this as completed Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants