-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build2 configuration #3
Comments
I took a look at the
|
Why is it a hard requirement? Module code is still C++ code.
Fair enough. However, it is something that should be supported. An explicit test case for such should be done instead of it just being assumed. |
We made it a hard requirement in
Yes, it is supported and yes, a separate test case is a good idea. I just think normally it makes sense for file names to have some correspondence to module name. |
I'll look at adding |
Yes, that sounds reasonable, thanks. Any chance you can grant me write access to this repository? I could then modify |
Invited. I'd like to get CI up sooner rather than later to ensure things keep working, so doing PRs would still be preferred rather than direct pushes, but direct is OK until #1 is done. Feel free to add an |
@boris-kolpackov Clang has chosen to recognise .cppm as module interface files (i.e. it implies a |
Yes, I am aware. And MSVC has chosen In the end, I am ok (for this repository) with any extension as long as it differs from the module implementation units, non-modules, and non-modular code (i.e., |
I've merged CI and added enforcements on the branch that CI must pass before merging can be done (also enforced for adminstrators). |
Just some update about clang: the earlier |
Would it make sense to add a |
Yes, I was planning to look into this when I had a chance, but if you want to take a stab at it, I would be grateful. We can discuss the approach here, if necessary. |
I was thinking about a script that downloads the install shell script that you recommand (e.g. https://download.build2.org/0.10.0/build2-install-0.10.0.sh) and try to make it noninteractive with the options |
Yes, that was my thinking as well! If we want to get a bit fancies, we can use https://download.build2.org/toolchain.sha256 to make it version-independent. It is safe to assume |
I'd like the |
@mathstuf Hm, wouldn't you want the |
With how modules are changing, I don't forsee every buildsystem/compiler combination being compatible forever. Using explicit versions means that checking out the Yes, the |
Ok, I see your point. |
@boris-kolpackov Here is the log:
|
@johan-boule I've replaced The fixed version is for now only available on stage so you will need to use that install script: https://stage.build2.org/0/ (Switching to stage is probably a good idea anyway since I am planning to catch up with the latest GCC modules changes, etc.) The repository cert fingerprint is |
I plan on respinning the image today or tomorrow to include some fixes which have been made upstream in GCC and in my CMake branch. That will allow me to do |
@mathstuf If you're willing to have a look again at my PR before publishing a new image, that would be a chance to include clang and build2. It's building fine now. |
Yep, will do. Seeing if I can't get GCC doing partitions properly right now. |
@johan-boule Nice, thanks for taking care or this! |
Just in case someone needs it. The latest beta version string can be obtained with: The latest stable version string with: (notice the |
Build2 supports modules. Build support for it would be nice to have for comparison.
Cc: @boris-kolpackov
The text was updated successfully, but these errors were encountered: