-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DND & v1.8.0 bug #311
Comments
Hey - Thanks for reporting! Looks like this regression feel through as a result of the change for the floating groups in 1.8.0 - will get that fixed with added tests. |
Here is a link to a CodeSandbox generated in the linked PR showing the dnd example working as you would expect with the new changes. I will look at getting this released as soon as possible. |
Fixed in published version 1.8.1. This was a very small and low risk change so was able to turn it around without much effort. |
Can confirm, it's fixed 🎉🎉 Just curious, would it still be possible to trigger the center drop target if no panels are open? Right now, if you try and drop on a dockview_center_event.mp4 |
That is a good point that I did not think about... let me take a look |
CodeSandbox generated from #313 https://codesandbox.io/s/dnd-dockview-h8gggv Sorry, I didn't consider that case - let me know if this covers the cases you have thought about and if so I'll take a look at publihsing another version. |
That works perfectly 🎉, thanks for the quick update! |
Published 1.8.2 with those fixes - thanks for the help in finding the bugs! |
Describe the bug
Hi, it seems that v1.8.0 has changed how dnd works. You can no longer drag and drop an element wherever on the layout, it seems to always take up the same spot.
dockview_180_dnd.mp4
Steps to reproduce the behavior:
Check the docview docs
Expected behavior
Expected similar to how it works in previous versions. Similar to how you can drag panels.
The text was updated successfully, but these errors were encountered: