Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DND & v1.8.0 bug #311

Closed
alakhpc opened this issue Jul 24, 2023 · 8 comments · Fixed by #312 or #313
Closed

DND & v1.8.0 bug #311

alakhpc opened this issue Jul 24, 2023 · 8 comments · Fixed by #312 or #313
Labels
bug Something isn't working

Comments

@alakhpc
Copy link

alakhpc commented Jul 24, 2023

Describe the bug
Hi, it seems that v1.8.0 has changed how dnd works. You can no longer drag and drop an element wherever on the layout, it seems to always take up the same spot.

dockview_180_dnd.mp4

Steps to reproduce the behavior:
Check the docview docs

Expected behavior
Expected similar to how it works in previous versions. Similar to how you can drag panels.

@mathuo mathuo linked a pull request Jul 24, 2023 that will close this issue
@mathuo
Copy link
Owner

mathuo commented Jul 24, 2023

Hey - Thanks for reporting!

Looks like this regression feel through as a result of the change for the floating groups in 1.8.0 - will get that fixed with added tests.

@mathuo
Copy link
Owner

mathuo commented Jul 24, 2023

Here is a link to a CodeSandbox generated in the linked PR showing the dnd example working as you would expect with the new changes. I will look at getting this released as soon as possible.

https://codesandbox.io/s/dnd-dockview-htv9dp

@mathuo mathuo added the bug Something isn't working label Jul 24, 2023
@mathuo mathuo reopened this Jul 24, 2023
@mathuo
Copy link
Owner

mathuo commented Jul 24, 2023

Fixed in published version 1.8.1. This was a very small and low risk change so was able to turn it around without much effort.

@alakhpc
Copy link
Author

alakhpc commented Jul 24, 2023

Can confirm, it's fixed 🎉🎉

Just curious, would it still be possible to trigger the center drop target if no panels are open?

Right now, if you try and drop on a Dockview with no panels, you can only do so at the very edges.
In v1.8.0 you could drop it anywhere as it triggered the center drop

dockview_center_event.mp4

@mathuo mathuo linked a pull request Jul 24, 2023 that will close this issue
@mathuo
Copy link
Owner

mathuo commented Jul 24, 2023

That is a good point that I did not think about... let me take a look

@mathuo
Copy link
Owner

mathuo commented Jul 24, 2023

CodeSandbox generated from #313

https://codesandbox.io/s/dnd-dockview-h8gggv

Sorry, I didn't consider that case - let me know if this covers the cases you have thought about and if so I'll take a look at publihsing another version.

@alakhpc
Copy link
Author

alakhpc commented Jul 24, 2023

That works perfectly 🎉, thanks for the quick update!

@mathuo mathuo reopened this Jul 24, 2023
@mathuo
Copy link
Owner

mathuo commented Jul 24, 2023

Published 1.8.2 with those fixes - thanks for the help in finding the bugs!

@mathuo mathuo closed this as completed Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants