Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate opening tabs in new Browser Window #360

Closed
mathuo opened this issue Oct 6, 2023 · 6 comments · Fixed by #364
Closed

Investigate opening tabs in new Browser Window #360

mathuo opened this issue Oct 6, 2023 · 6 comments · Fixed by #364
Labels
done enhancement New feature or request
Milestone

Comments

@mathuo
Copy link
Owner

mathuo commented Oct 6, 2023

          Thanks for the explanation!  Stoked for this to be working.  This is perhaps one of my favourite features of switching over to Dockview.

Out of curiosity, anything on the roadmap to pull a tab out into a totally new browser window?

Originally posted by @michaelsharpe in #344 (comment)

@mathuo mathuo changed the title Investigate opens tabs in new Browser Window Investigate opening tabs in new Browser Window Oct 6, 2023
@mathuo
Copy link
Owner Author

mathuo commented Oct 20, 2023

Screenshot of very early work in progress.

Animation

@mathuo mathuo linked a pull request Oct 20, 2023 that will close this issue
@mathuo mathuo added this to the v1.9.0 milestone Oct 20, 2023
@michaelsharpe
Copy link

This is so exciting!

@mathuo
Copy link
Owner Author

mathuo commented Dec 28, 2023

@michaelsharpe I've published the current state under an experimental build. I believe this is getting close to a production-grade solution but it may be subject to some change. Any feedback appreicated as always.

npm install dockview@0.0.0-experimental-1264055-20231228
  • The state of popout windows is serialized with the layout.
  • A popout window requires a page to attach to, by default this is /popout.html. You can specify your own page location which I believe most users will need to do. This page should be a blank .html page.
  addPopoutGroup(
      item: IDockviewPanel | DockviewGroupPanel,
      options?: {
          position?: Box;
          popoutUrl?: string;
      }
  ): void;

From the primary api

api.addPopoutGroup(group);

From within a panel

props.containerApi.addPopoutGroup(props.api.group);

@michaelsharpe
Copy link

Awesome!!! I'll try it out and let you know how it goes.

@mathuo mathuo reopened this Jan 1, 2024
@mathuo
Copy link
Owner Author

mathuo commented Jan 5, 2024

Refer to #365 for beta builds and documentation of this feature.

@mathuo mathuo added enhancement New feature or request done labels Jan 10, 2024
@mathuo
Copy link
Owner Author

mathuo commented Jan 15, 2024

This has been release in version 1.9.0. Docs here.

@mathuo mathuo closed this as completed Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants