Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: onDidMaximizedGroupChange misspelled as onDidMaxmizedGroupChange #495

Closed
patrickemoore opened this issue Feb 8, 2024 · 2 comments · Fixed by #500
Closed

API: onDidMaximizedGroupChange misspelled as onDidMaxmizedGroupChange #495

patrickemoore opened this issue Feb 8, 2024 · 2 comments · Fixed by #500
Labels
enhancement New feature or request
Milestone
v1.10.0

Comments

@patrickemoore
Copy link

Describe the bug

The container api has onDidMaximizedGroupChange misspelt as onDidMaxmizedGroupChange (note the missing "i").

May seem minor, but just thought i'd raise as I didnt find it when i seached the api TS files for it with the correct spelling.

Amazing repo btw!

To Reproduce

component.api.d.ts line 459 on 1.9.2
@patrickemoore patrickemoore changed the title API: onDidMaximizedGroupChange misspelt as onDidMaxmizedGroupChange API: onDidMaximizedGroupChange misspelled as onDidMaxmizedGroupChange Feb 8, 2024
@mathuo
Copy link
Owner

mathuo commented Feb 8, 2024

Thanks for the pointer - will get that fixed on the next release!

@mathuo mathuo added the enhancement New feature or request label Feb 8, 2024
@mathuo mathuo added this to the v1.10.0 milestone Feb 8, 2024
@mathuo mathuo mentioned this issue Feb 8, 2024
Closed
@mathuo mathuo linked a pull request Feb 9, 2024 that will close this issue
chore: fix typos #500
Merged
@mathuo mathuo reopened this Feb 9, 2024
@mathuo
Copy link
Owner

mathuo commented Feb 25, 2024

Released in 1.10.0 https://dockview.dev/

@mathuo mathuo closed this as completed Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging a pull request may close this issue.

chore: fix typos mathuo/dockview
2 participants
@mathuo @patrickemoore