Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api.toJSON() and api.fromJSON() should be be renamed, as they use JS Objects and not JSON. #619

Open
brochington opened this issue May 29, 2024 · 0 comments

Comments

@brochington
Copy link

Currently the api.toJSON() and api.fromJSON() methods act upon deserialized object representations of the layout (JS Objects). This can lead to some confusion, as it's not technically JSON that they are using.

There is nothing wrong with the api methods taking JS objects, but I do feel like they should be renamed to reflect what is actually happening, perhaps something like api.saveLayout() and api.loadLayout().

@brochington brochington changed the title api.toJSON() and api.fromJSON() should be be renamed, or updated to handle JSON strings. api.toJSON() and api.fromJSON() should be be renamed, as they use JS Objects and not JSON. May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant