Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MultiTaskLassoCV and MultiTaskLasso #114

Merged
merged 5 commits into from Apr 20, 2020

Conversation

agramfort
Copy link
Collaborator

@mathurinm I tried to add MultiTaskLassoCV and MultiTaskLasso to help @ja-che with his experiments but the test does not end. It seems like it's not converging.

@mathurinm can you have a look?

also you'll see that mtl_path is not consistent in API with sklearn lasso_path

wdyt?

@mathurinm
Copy link
Owner

I removed fit_intercept=True testing (not supported yet, do you need it for this project?)

I used the datafit scaling by n_samples in the cython code to harmonize with both celer's lasso and sklearn's MTL.

Now the tests pass locally.

By the way do you know why Travis is not triggered?

@mathurinm
Copy link
Owner

I will configure travis to trigger builds for fork's PR. It is ongoing maintenance so I will do it later. Thank you @agramfort

@agramfort
Copy link
Collaborator Author

works for me !

do you want to activate CIs before merging to avoid breaking something?

@mathurinm
Copy link
Owner

yes :)

@agramfort
Copy link
Collaborator Author

agramfort commented Apr 20, 2020 via email

@codecov-io
Copy link

codecov-io commented Apr 20, 2020

Codecov Report

Merging #114 into master will increase coverage by 2.04%.
The diff coverage is 94.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   79.17%   81.22%   +2.04%     
==========================================
  Files          11       11              
  Lines         658      719      +61     
  Branches       97       98       +1     
==========================================
+ Hits          521      584      +63     
+ Misses        105      104       -1     
+ Partials       32       31       -1     
Impacted Files Coverage Δ
celer/homotopy.py 81.29% <60.00%> (+3.35%) ⬆️
celer/dropin_sklearn.py 96.22% <92.85%> (-1.28%) ⬇️
celer/tests/test_lasso.py 100.00% <100.00%> (ø)
celer/tests/test_mtl.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be79116...55b4e46. Read the comment docs.

@ja-che
Copy link

ja-che commented Apr 20, 2020

Thanks for the help @mathurinm. In our experiment, we only need fit_intercept=False.

@agramfort
Copy link
Collaborator Author

agramfort commented Apr 20, 2020 via email

@mathurinm mathurinm merged commit b1f0c3c into mathurinm:master Apr 20, 2020
@mathurinm
Copy link
Owner

Keep me posted about the numericq if I can give it a more detailed look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants