New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add MultiTaskLassoCV and MultiTaskLasso #114
Conversation
I removed fit_intercept=True testing (not supported yet, do you need it for this project?) I used the datafit scaling by n_samples in the cython code to harmonize with both celer's lasso and sklearn's MTL. Now the tests pass locally. By the way do you know why Travis is not triggered? |
I will configure travis to trigger builds for fork's PR. It is ongoing maintenance so I will do it later. Thank you @agramfort |
works for me ! do you want to activate CIs before merging to avoid breaking something? |
yes :) |
push an empty line and let's see?
… |
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
==========================================
+ Coverage 79.17% 81.22% +2.04%
==========================================
Files 11 11
Lines 658 719 +61
Branches 97 98 +1
==========================================
+ Hits 521 584 +63
+ Misses 105 104 -1
+ Partials 32 31 -1
Continue to review full report at Codecov.
|
Thanks for the help @mathurinm. In our experiment, we only need fit_intercept=False. |
@ja-che I am trying your code with the new code but so far not clear how
much it helps.
I may need @mathurinm to look :(
… |
Keep me posted about the numericq if I can give it a more detailed look |
@mathurinm I tried to add MultiTaskLassoCV and MultiTaskLasso to help @ja-che with his experiments but the test does not end. It seems like it's not converging.
@mathurinm can you have a look?
also you'll see that mtl_path is not consistent in API with sklearn lasso_path
wdyt?