FIX - Compatibility with scikit-learn
1.2.dev
#279
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scikit-learn
1.2.dev breaks down the actual code.debug_script.py
provides a small snippet to reproduce.investigation
scikit-learn
seems to have added a validation step of the class parameters at thefit
moment.our Lasso estimator doesn't have the same signature as the scikit-learn (e.g.
copy_X
andrandom_state
), though we inherit from it.Therefore we get an error when comparing the constructor arguments with the parent class
click to expend error
potential fix
A straightforward fix would be to override
_validate_params
. But I don't think it's a reliable way to do it.click to expend code