Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix when no selector defined #4

Merged
merged 2 commits into from Sep 7, 2014
Merged

Fix when no selector defined #4

merged 2 commits into from Sep 7, 2014

Conversation

mgaitan
Copy link
Contributor

@mgaitan mgaitan commented Sep 6, 2014

the default selector is the whole page ('html') but this is applied through PyQuery.find wich traverses down.
example:

In [2]: PyQuery('<html>hello</html>').find('html')
Out[2]: []

In [3]: PyQuery('<html>hello</html>')('html')
Out[3]: [<html>]

@mgaitan
bugfix when the selector isn't. defined.
7c5e0e7 
pq.find('html') doesnt return anything but pq('html') does
@mgaitan
one item
b31b77f
@matiasb
Copy link
Owner

matiasb commented Sep 7, 2014

Looks good!
Merging, thanks.

matiasb added a commit that referenced this pull request Sep 7, 2014
@matiasb
Merge pull request #4 from mgaitan/fix_no_selector_defined
b45d847 
Fix when no selector is provided.
@matiasb matiasb merged commit b45d847 into matiasb:master Sep 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mgaitan @matiasb