Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

PersonMapper is wrom? #47

Closed
matiasdelellis opened this issue Nov 13, 2018 · 5 comments
Closed

PersonMapper is wrom? #47

matiasdelellis opened this issue Nov 13, 2018 · 5 comments

Comments

@matiasdelellis
Copy link
Owner

See:

https://github.com/matiasdelellis/facerecognition/blob/master/lib/Db/PersonMapper.php#L38

It is associated with the Image entity.. 馃槙

@matiasdelellis matiasdelellis changed the title FaceNewMapper is wrom? PersonMapper is wrom? Nov 13, 2018
@stalker314314
Copy link
Collaborator

Ops, sorry about this, fixed!
(this is what you get for copy/pasting stuff:D)

@matiasdelellis
Copy link
Owner Author

Geat, but in spite of that, the mapper was being used and worked correctly.

@matiasdelellis
Copy link
Owner Author

Just reopen until we're sure everything is working correctly.

@stalker314314
Copy link
Collaborator

It was working because this parameter (entityClass) is only needed if we are doing actual mapping, from columns to class fields (mapRowToEntity), and then mapper needs to now exact class it is going to instantiate and set fields to. This applies to generic methods, like findEntities etc. I was not using those generic methods and hence, I never noticed my copy-pasta:) I will still leave to you to close issue, if my explanation makes sense to you:)

@matiasdelellis
Copy link
Owner Author

OK .. Beyond that you convinced me, try "the whole circuit" and it works correctly.. 馃槈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants