Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending metadata (like headers) inside body as part of the form data should be optional #2

Closed
mohamnag opened this issue Jul 22, 2015 · 5 comments

Comments

@mohamnag
Copy link

There are some situations where the server side implementation is not capable of handling additional data sent as part of form or it may cause a major complexity to adopt them.
Current state of this plugin adds some of the HTTP headers as part of form data, this behaviour if not disabled per default, shall be at least configurable.

@mohamnag
Copy link
Author

this issue references #1 which was closed in favour of further discussions here.

@matiasgali matiasgali changed the title Sending meta data (like headers) inside body as part of the form data shall be optional Sending metadata (like headers) inside body as part of the form data should be optional Jul 22, 2015
@matiasgali
Copy link
Owner

Let's say you actually need the extra headers as metadata, what would you need to allow them in AWS signature V4 POST requests? Allowing to set custom metadata would be enought?

@matiasgali
Copy link
Owner

@mohamnag that last commit should be enough to solve the issue.

Please checkout the new section in the README and try it out.

Reopen the issue if there's something off.

@mohamnag
Copy link
Author

@matiasgagliano it seems good enough to fix my problem, I will test it and in case the problem persists will reopen this ticket here. thanks.

by the way, why don't you publish this in bower?

@matiasgali
Copy link
Owner

Published to Bower.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants