Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

[馃敹 Change request ]: Activations should be case insensitive #44

Closed
3 of 10 tasks
matiasvlevi opened this issue Dec 4, 2021 · 2 comments
Closed
3 of 10 tasks
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@matiasvlevi
Copy link
Owner

matiasvlevi commented Dec 4, 2021

Change

We could use toLocaleLowerCase to specify the activations functions without worrying about capitalization.

Type

  • Dann
  • Matrix
  • Layer
  • Activation functions
  • Loss functions
  • Pool functions
  • Datasets
  • Documentation
  • tests & examples
  • Other

Examples

these statements would all be valid if we ignore capitalization.

nn.addHiddenLayer(x, 'leakyrelu');
nn.addHiddenLayer(x, 'LEAKYRELU');
nn.addHiddenLayer(x, 'leakyReLU');

Additional context

This also means all activation names need to be in lowercase, and when we add a new activation with Add.activation, we should also convert the input name to lowercase.

Changes should be in these methods:

  • Layer.stringToFunc parses the activation names into an object containing, the derivative & the activation.
  • Add.activation adds new activations, and also needs to respect the case insensitivity.
  • Other Dann methods using activation strings will need some minor adjusments.
@matiasvlevi matiasvlevi added enhancement New feature or request good first issue Good for newcomers labels Dec 4, 2021
@and1can
Copy link
Contributor

and1can commented Dec 4, 2021

Hi @matiasvlevi ,

I have been looking into this issue. Is it okay if I work on this?

@matiasvlevi
Copy link
Owner Author

matiasvlevi commented Dec 5, 2021

Yep it is! I am assigning you to this issue. Let me know if you need any help/clarifications with the library.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants