Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

npm install fails #54

Closed
atvanguard opened this issue Mar 8, 2019 · 3 comments
Closed

npm install fails #54

atvanguard opened this issue Mar 8, 2019 · 3 comments

Comments

@atvanguard
Copy link
Contributor

In file included from ../../nan/nan.h:192:
../../nan/nan_maybe_43_inl.h:112:15: error: no member named 'ForceSet' in 'v8::Object'
  return obj->ForceSet(isolate->GetCurrentContext(), key, value, attribs);

This is a known issue with older version of nan package (<= 2.7) with newer versions of node (>= 10).

@0xAshish
Copy link
Contributor

0xAshish commented Mar 8, 2019

@atvanguard please try it with node@8.11.3. some crypto packages are on node8.

@atvanguard
Copy link
Contributor Author

atvanguard commented Mar 8, 2019

Fix is trivial. do you think regenerating package-lock could have side-effects?

@0xAshish
Copy link
Contributor

0xAshish commented Mar 8, 2019

will see if anything fails in CI(should work fine), thanks for PR 👍.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants