Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Whitelisting instead of Blacklisting #5

Closed
gentle-noah opened this issue Feb 16, 2018 · 4 comments
Closed

Feature Request: Whitelisting instead of Blacklisting #5

gentle-noah opened this issue Feb 16, 2018 · 4 comments
Labels
kind/feature A request for a new feature.

Comments

@gentle-noah
Copy link

Hey, I absolutely love this. Thank you so much for your hard work on graphql-shield. One thing that I feel would be super useful is a whitelisting in place of blacklisting feature. Locking everything down and then explicitly exposing access would go a long way to help people develop better habits, be more involved with this part of the process and I think create all around more secure systems.

@maticzav
Copy link
Owner

Hey @gentle-noah 👋

I am so happy to hear that you love graphql-shield. I couldn't agree with you more! The first version was already whitelisting instead of blacklisting, but there were some major issues with permissions tree creation and I postponed the whole thing so that I could get users' feedback faster.

I have found the solution to previous problems and will be adding whitelisting back to the workflow as soon as possible.

Thank you so much for your feedback! 🙂

@schickling
Copy link

I'm pretty convinced that blacklisting is still the better default but I agree, that there should be an option to make graphql-shield whitelist-based.

@gentle-noah
Copy link
Author

@schickling - totally agree here. I think most people will find the blacklisting more helpful and easier to implement by default. There are a few industries that will find the whitelisting option more useful, which is why it would be great to have it as an option. I'm mostly thinking about any health tech that needs to be HIPPA compliant in the US and most fintech applications. Having the option makes this awesome tech much more accessible to companies in those space.

@maticzav maticzav added the kind/feature A request for a new feature. label Jun 19, 2018
@maticzav maticzav added this to To do in GraphQL Shield 3.0 Jul 6, 2018
@maticzav maticzav moved this from To do to In progress in GraphQL Shield 3.0 Jul 9, 2018
@maticzav maticzav moved this from In progress to Done in GraphQL Shield 3.0 Jul 19, 2018
@maticzav maticzav mentioned this issue Jul 24, 2018
@maticzav
Copy link
Owner

We have introduced this feature with #119. In light of it, I'll close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A request for a new feature.
Projects
No open projects
Development

No branches or pull requests

3 participants